Segher Boessenkool <seg...@kernel.crashing.org> writes: > On Thu, Feb 25, 2021 at 02:10:03PM +1100, Daniel Axtens wrote: >> +#define PPC_RAW_LQ(t, a, dq) (0xe0000000 | ___PPC_RT(t) | >> ___PPC_RA(a) | (((dq) & 0xfff) << 3)) > > Please keep the operand order the same as for the assembler insns? So > t,dq,a here. > > It should be ((dq) & 0x0fff) << 4) . > >> +#define PPC_RAW_STQ(t, a, ds) (0xf8000002 | ___PPC_RT(t) | >> ___PPC_RA(a) | (((ds) & 0xfff) << 3)) > > And t,ds,a here. (But it should use "s" instead of "t" preferably, and > use ___PPC_RS, because it is a source field, not a target). > > It should be ((ds) & 0x3fff) << 2) as well. >
Ah, thank you. I'll fix this up. Kind regards, Daniel > > Segher
