Hi Oliver, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v5.8-rc4 next-20200706] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Oliver-O-Halloran/powerpc-eeh-Remove-eeh_dev_phb_init_dynamic/20200706-103630 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig-r006-20200706 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': >> arch/powerpc/kernel/of_platform.c:66:2: error: implicit declaration of >> function 'eeh_phb_pe_create' [-Werror=implicit-function-declaration] 66 | eeh_phb_pe_create(phb); | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +/eeh_phb_pe_create +66 arch/powerpc/kernel/of_platform.c 28 29 /* The probing of PCI controllers from of_platform is currently 30 * 64 bits only, mostly due to gratuitous differences between 31 * the 32 and 64 bits PCI code on PowerPC and the 32 bits one 32 * lacking some bits needed here. 33 */ 34 35 static int of_pci_phb_probe(struct platform_device *dev) 36 { 37 struct pci_controller *phb; 38 39 /* Check if we can do that ... */ 40 if (ppc_md.pci_setup_phb == NULL) 41 return -ENODEV; 42 43 pr_info("Setting up PCI bus %pOF\n", dev->dev.of_node); 44 45 /* Alloc and setup PHB data structure */ 46 phb = pcibios_alloc_controller(dev->dev.of_node); 47 if (!phb) 48 return -ENODEV; 49 50 /* Setup parent in sysfs */ 51 phb->parent = &dev->dev; 52 53 /* Setup the PHB using arch provided callback */ 54 if (ppc_md.pci_setup_phb(phb)) { 55 pcibios_free_controller(phb); 56 return -ENODEV; 57 } 58 59 /* Process "ranges" property */ 60 pci_process_bridge_OF_ranges(phb, dev->dev.of_node, 0); 61 62 /* Init pci_dn data structures */ 63 pci_devs_phb_init_dynamic(phb); 64 65 /* Create EEH PE for the PHB */ > 66 eeh_phb_pe_create(phb); 67 68 /* Scan the bus */ 69 pcibios_scan_phb(phb); 70 if (phb->bus == NULL) 71 return -ENXIO; 72 73 /* Claim resources. This might need some rework as well depending 74 * whether we are doing probe-only or not, like assigning unassigned 75 * resources etc... 76 */ 77 pcibios_claim_one_bus(phb->bus); 78 79 /* Add probed PCI devices to the device model */ 80 pci_bus_add_devices(phb->bus); 81 82 return 0; 83 } 84 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
