Hi Bryan,

On Tue, 6 May 2008 03:28:13 +0100 Bryan O'Donoghue <[EMAIL PROTECTED]> wrote:
>
> +static void __init asp834x_init_IRQ(void)
> +{
> +     struct device_node *np;
> +
> +     np = of_find_node_by_type(NULL, "ipic");
> +     if (!np)
> +             return;
> +
> +     ipic_init(np, 0);

You need an "of_node_put(np)" here to drop the reference gained in
"of_find_node_by_type".

> +static struct of_device_id asp8347_ids[] = {

Please make this __initdata.

-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgpIa2Ikou5SG.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to