Re: [PATCH 2/7] powerpc/powernv/iov: Don't add VFs to iommu group during PE config

[Alexey Kardashevskiy]

On 06/04/2020 13:07, Oliver O'Halloran wrote:
> In pnv_ioda_setup_vf_PE() we register an iommu group for the VF PE
> then call pnv_ioda_setup_bus_iommu_group() to add devices to that group.
> However, this function is called before the VFs are scanned so there's
> no devices to add.
> 
> Signed-off-by: Oliver O'Halloran <ooh...@gmail.com>



Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru>


> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c 
> b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 57d3a6af1d52..2c340504fa77 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1622,7 +1622,6 @@ static void pnv_ioda_setup_vf_PE(struct pci_dev *pdev, 
> u16 num_vfs)
>  #ifdef CONFIG_IOMMU_API
>               iommu_register_group(&pe->table_group,
>                               pe->phb->hose->global_number, pe->pe_number);
> -             pnv_ioda_setup_bus_iommu_group(pe, &pe->table_group, NULL);
>  #endif
>       }
>  }
> 

-- 
Alexey