On Tue, 2008-04-22 at 15:22 +0200, Segher Boessenkool wrote: > >>>> +static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq, > >>>> + struct msi_msg *msg) > > > No I mean I'm confused about the maths here. If we pull out the > > variables it boils down to: > > > > data = ((hwirq / 32) << 5) | ((hwirq % 32) & 0x1F) > > > > Which doesn't seem to actually do anything? > > It's not a no-op, because hwirq is signed. It probably should be > unsigned, like most things.
You'll have to draw me a picture. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
