+static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq, + struct msi_msg *msg)
No I mean I'm confused about the maths here. If we pull out the variables it boils down to: data = ((hwirq / 32) << 5) | ((hwirq % 32) & 0x1F) Which doesn't seem to actually do anything?
It's not a no-op, because hwirq is signed. It probably should be unsigned, like most things. Segher _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
