On Tuesday 22 April 2008 17:36, Scott Wood wrote: > On Tue, Apr 22, 2008 at 05:21:49PM +0200, Laurent Pinchart wrote: > > As the openfirmware + gpio + mdio driver might benefit non-powerpc > > platforms, I plan to create a new driver (probably > > drivers/net/phy/mdio-ofgpio.c) that mostly ports > > drivers/net/fs_enet/mii-bitbang.c to the gpiolib (this replaces around 90% > > of the code). > > > > If both drivers/net/fs_enet/mii-bitbang.c and > > drivers/net/phy/mdio-ofgpio.c must live together, > > The only reason I can see for that would be if the gpiolib version > doesn't work on arch/ppc -- but that's not going to be a problem for very > much longer.
Didn't you mention platforms such as ep8248e as well, where mdiobb would be the only gpiolib user ? > > I'll have a problem in drivers/net/fs_enet/fs_enet-main.c. The net > > device probing code searches the device tree for an associated PHY, and > > creates a PHY id from the PHY node. As the id will be generated from > > different bus ids in the two mdio drivers (the bus number is the > > register address for drivers/net/fs_enet/mii-bitbang.c, and is the gpio > > index for drivers/net/phy/mdio-ofgpio.c), things will break. > > > > Any idea regarding how to get rid of that fs_enet/mii-bitbang hardcoded > > dependency ? > > If mii-bitbang is only used on arch/ppc, then #ifdef CONFIG_PPC_MERGE > should do it. Ok. > It'd be nice to be able to give phylib an OF node rather than a string, > though... Doesn't phylib have non-OF users ? -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpveIOQE8sni.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
