On Mar 31, 2008, at 10:42 PM, Paul Mackerras wrote:
Kumar Gala writes:
Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use
it in
places that before would have caused recursive includes.
For example to use phys_addr_t in <asm/page.h> we would have included
<asm/mmu.h> which would have possibly included <asm/mmu-hash64.h>
which
includes <asm/page.h>. Wheeee recursive include.
In general this looks fine. I wonder if you should use u64 rather
than unsigned long long. Since CONFIG_PHYS_64BIT=n on 64-bit machines
(which is itself somewhat counterintuitive) we will actually use
unsigned long on 64-bit machines, so it matters less than I originally
thought, but it would be worth explaining that in a comment and/or the
commit message.
We could change it to be:
/* Physical address used by some IO functions */
#if defined(CONFIG_PPC64) || defined(CONFIG_PHYS_64BIT)
typedef u64 phys_addr_t;
#else
typedef u32 phys_addr_t;
#endif
This seems a bit more self documenting which is always nice (and I can
add a comment in the commit message about CONFIG_PHYS_64BIT only
making sense on ppc32).
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
