Kumar Gala writes: > Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use it in > places that before would have caused recursive includes. > > For example to use phys_addr_t in <asm/page.h> we would have included > <asm/mmu.h> which would have possibly included <asm/mmu-hash64.h> which > includes <asm/page.h>. Wheeee recursive include.
In general this looks fine. I wonder if you should use u64 rather than unsigned long long. Since CONFIG_PHYS_64BIT=n on 64-bit machines (which is itself somewhat counterintuitive) we will actually use unsigned long on 64-bit machines, so it matters less than I originally thought, but it would be worth explaining that in a comment and/or the commit message. Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
