Fill the struct uart_port->mapsize field and use it, insteaf of
hardcoded values in many places. This makes the code layout a bit
more consistent and easily allows using generic helpers for the
io memory handling.

Candidates for such helpers could be eg. the request+ioremap and
iounmap+release combinations.

Signed-off-by: Enrico Weigelt <i...@metux.net>
---
 drivers/tty/serial/zs.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/zs.c b/drivers/tty/serial/zs.c
index adbfe79..ab432ba 100644
--- a/drivers/tty/serial/zs.c
+++ b/drivers/tty/serial/zs.c
@@ -986,14 +986,14 @@ static void zs_release_port(struct uart_port *uport)
 {
        iounmap(uport->membase);
        uport->membase = 0;
-       release_mem_region(uport->mapbase, ZS_CHAN_IO_SIZE);
+       release_mem_region(uport->mapbase, uport->mapsize);
 }
 
 static int zs_map_port(struct uart_port *uport)
 {
        if (!uport->membase)
                uport->membase = ioremap_nocache(uport->mapbase,
-                                                ZS_CHAN_IO_SIZE);
+                                                uport->mapsize);
        if (!uport->membase) {
                dev_err(port->dev, "zs: Cannot map MMIO\n");
                return -ENOMEM;
@@ -1005,13 +1005,13 @@ static int zs_request_port(struct uart_port *uport)
 {
        int ret;
 
-       if (!request_mem_region(uport->mapbase, ZS_CHAN_IO_SIZE, "scc")) {
+       if (!request_mem_region(uport->mapbase, uport->mapsize, "scc")) {
                dev_err(uport->dev, "zs: Unable to reserve MMIO resource\n");
                return -EBUSY;
        }
        ret = zs_map_port(uport);
        if (ret) {
-               release_mem_region(uport->mapbase, ZS_CHAN_IO_SIZE);
+               release_mem_region(uport->mapbase, uport->mapsize);
                return ret;
        }
        return 0;
@@ -1113,6 +1113,7 @@ static int __init zs_probe_sccs(void)
                        uport->flags    = UPF_BOOT_AUTOCONF;
                        uport->ops      = &zs_ops;
                        uport->line     = chip * ZS_NUM_CHAN + side;
+                       uport->mapsize  = ZS_CHAN_IO_SIZE;
                        uport->mapbase  = dec_kn_slot_base +
                                          zs_parms.scc[chip] +
                                          (side ^ ZS_CHAN_B) * ZS_CHAN_IO_SIZE;
-- 
1.9.1

Reply via email to