On 03/18, Sudeep Holla wrote: > > On Mon, Mar 18, 2019 at 06:20:24PM +0100, Oleg Nesterov wrote: > > > > Again, to me this patch just makes the code look worse. Honestly, I don't > > think that the new (badly named) ptrace_syscall_enter() hook makes any > > sense. > > > > Worse because we end up reading current_thread_info->flags twice ?
Mostly because in my opinion ptrace_syscall_enter() buys nothing but makes the caller's code less readable/understandable. Sure, this is subjective. Oleg.
