Hi Scott, On Monday 17 March 2008 16:33, Scott Wood wrote: > On Mon, Mar 10, 2008 at 01:17:01PM +0100, Laurent Pinchart wrote: > > On Friday 07 March 2008 17:21, Scott Wood wrote: > > > cpm2_reset() doesn't currently actually reset the CPM, for some reason > > > (unlike cpm1). This should probably be fixed, though then we'd have to > > > deal with assigning SMC parameter RAM addresses ourselves. > > > > I had overlooked that. Resetting the CPM in cpm2_reset() helps. Is there > > any reason not to rset the CPM in cpm2_reset() ? > > The only issue I'm aware of other than the SMC parameter RAM relocation is > that the reset can't happen if the early udbg printk is being used. > > > How should SMC parameter RAM assignment be handled ? I'm not very > > familiar with the CPM1, > > CPM1 has hardcoded SMC parameter RAM addresses, so it's not relevant here. > > > but for CPM2 the cpm_uart driver could easily cpm_dpalloc() parameter > > RAM. > > It can, yes. Patches welcome. :-)
I'm working on a patch. I'm not sure how to handle the early udbg printk problem, so the first version will just ignore it. Best regards, -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpJ3u1AGlujw.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
