Hmm... interesting points. I guess my feeling was that XILINX_DRIVERS could be a more broadly configurable option, with some of these ideas in mind. Currently, it's hidden by default, but we could easily change this to be visible by default, or selected by a broader number of architectures. I tend to think about them as a group: What if x86 *did* support the primitives needed by these drivers, then if the individual drivers depend on XILINX_DRIVERS, then the modification could be made in one spot. By your suggestion, we would have to modify each one independantly.
I do dislike the hodgepodge of different configuration dependencies (such as Sysace)... It makes sense to me to have them be uniformly available. If they are all going to be PPC32 || microblaze, then it seems to me like there should be an intermediate configuration option that expresses exactly that set. Would you feel differently if we flipped the dependencies around, like XILINX_DRIVERS depends on PPC32 || MICROBLAZE? Steve -----Original Message----- From: [EMAIL PROTECTED] on behalf of Grant Likely Sent: Tue 3/18/2008 9:15 PM To: Stephen Neuendorffer Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] Subject: Re: [PATCH] [RFC] Xilinx: Add generic configuration option to enable all xilinx drivers. On Tue, Feb 12, 2008 at 3:31 PM, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > In the future, this will be used to provide similar configuration for > PowerPC and Microblaze. It may also be convenient for those using > Xilinx cores as peripherals for external processors, rather than > explicitly having a dependance on the processor architecture. > > Signed-off-by: Stephen Neuendorffer <[EMAIL PROTECTED]> > > --- > > Grant, > > This is the patch, updated for all of the drivers that I think are in > the tree. I think the problematic parts may be the ppc part, which is > required for backward compatibility. If this has to wait until ppc > dies, then that's fine with me, I guess. > > It may also be better to clean up the Kconfig lines for Sysace and > framebuffer drivers by having PPC32 or PPC4xx select XILINX_DRIVERS. > My understanding is that those config options are there because of > people using external PPCs with those devices in the FPGA. Hey Steve; I haven't forgotten about this patch, but I've been thinking about it some more and I'm coming to the conclusion that it might just be better to eliminate driver dependence on XILINX_DRIVERS and XILINX_VIRTEX entirely and instead just make each of them "depends on PPC32 || MICROBLAZE". There's no reason to restrict compiling these drivers to platforms that are known to have xilinx parts on them. I know that in most cases they will not be used, but by relaxing the dependencies they will get compile tested on more platforms than they are now and they'll get picked up for make allyesconfigs builds. In my mind this means greater chances of compile bugs getting found and reported. In fact, it would be nice to drop the PPC32 || MICROBLAZE dependency too; but I think the drivers are using io primitives at the moment that are not portable to x86. Thoughts? Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
