Hi Benjamin, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v4.20-rc6 next-20181210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/powerpc-Fix-bogus-usage-of-MSR_RI-on-BookE-and-40x/20181211-110017 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-ppa8548_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All errors (new ones prefixed by >>): arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': >> arch/powerpc/sysdev/fsl_rio.c:115:17: error: 'MSR_RI' undeclared (first use >> in this function); did you mean 'MSR_BE'? regs->msr |= MSR_RI; ^~~~~~ MSR_BE arch/powerpc/sysdev/fsl_rio.c:115:17: note: each undeclared identifier is reported only once for each function it appears in vim +115 arch/powerpc/sysdev/fsl_rio.c a52c8f52 Alexandre Bounine 2010-05-26 96 ff33f182 Li Yang 2010-06-18 97 #ifdef CONFIG_E500 cce1f106 Shaohui Xie 2010-11-18 98 int fsl_rio_mcheck_exception(struct pt_regs *regs) a52c8f52 Alexandre Bounine 2010-05-26 99 { 82a9a480 Scott Wood 2011-06-16 100 const struct exception_table_entry *entry; 82a9a480 Scott Wood 2011-06-16 101 unsigned long reason; 82a9a480 Scott Wood 2011-06-16 102 82a9a480 Scott Wood 2011-06-16 103 if (!rio_regs_win) 82a9a480 Scott Wood 2011-06-16 104 return 0; a52c8f52 Alexandre Bounine 2010-05-26 105 a52c8f52 Alexandre Bounine 2010-05-26 106 reason = in_be32((u32 *)(rio_regs_win + RIO_LTLEDCSR)); a52c8f52 Alexandre Bounine 2010-05-26 107 if (reason & (RIO_LTLEDCSR_IER | RIO_LTLEDCSR_PRT)) { a52c8f52 Alexandre Bounine 2010-05-26 108 /* Check if we are prepared to handle this fault */ a52c8f52 Alexandre Bounine 2010-05-26 109 entry = search_exception_tables(regs->nip); a52c8f52 Alexandre Bounine 2010-05-26 110 if (entry) { a52c8f52 Alexandre Bounine 2010-05-26 111 pr_debug("RIO: %s - MC Exception handled\n", a52c8f52 Alexandre Bounine 2010-05-26 112 __func__); a52c8f52 Alexandre Bounine 2010-05-26 113 out_be32((u32 *)(rio_regs_win + RIO_LTLEDCSR), a52c8f52 Alexandre Bounine 2010-05-26 114 0); a52c8f52 Alexandre Bounine 2010-05-26 @115 regs->msr |= MSR_RI; 61a92f70 Nicholas Piggin 2016-10-14 116 regs->nip = extable_fixup(entry); a52c8f52 Alexandre Bounine 2010-05-26 117 return 1; a52c8f52 Alexandre Bounine 2010-05-26 118 } a52c8f52 Alexandre Bounine 2010-05-26 119 } a52c8f52 Alexandre Bounine 2010-05-26 120 cce1f106 Shaohui Xie 2010-11-18 121 return 0; a52c8f52 Alexandre Bounine 2010-05-26 122 } cce1f106 Shaohui Xie 2010-11-18 123 EXPORT_SYMBOL_GPL(fsl_rio_mcheck_exception); ff33f182 Li Yang 2010-06-18 124 #endif a52c8f52 Alexandre Bounine 2010-05-26 125 :::::: The code at line 115 was first introduced by commit :::::: a52c8f521fed43bce53451d7dfddf2b42a2af689 rapidio, powerpc/85xx: Add MChk handler for SRIO port :::::: TO: Alexandre Bounine <alexandre.boun...@idt.com> :::::: CC: Linus Torvalds <torva...@linux-foundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
