Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

[Gustavo A. R. Silva]

On 10/11/18 3:35 AM, Kees Cook wrote:
> On Wed, Oct 10, 2018 at 5:32 PM, Michael Ellerman <m...@ellerman.id.au> wrote:
>> Kees Cook <keesc...@chromium.org> writes:
>>> On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman <m...@ellerman.id.au> 
>>> wrote:
>>>> Warn whenever a switch statement has a fallthrough without a comment
>>>> annotating it.
>>>>
>>>> Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
>>>
>>> Yes please. :)
>>>
>>> Reviewed-by: Kees Cook <keesc...@chromium.org>
>>
>> Haha, thanks.
>>
>> It still pops a few errors, including in linux/signal.h & compat.h, so
>> it's somewhat aspirational until we can get those fixed up :)
> 
> Gustavo, any chance you can target those two files? It could get us a
> whole architecture using the flag. :)
> 

Yep. Sure thing.

I'm already taking a look.

Thanks
--
Gustavo