Hello Michael, On Fri, Sep 21, 2018 at 01:02:45PM +1000, Michael Neuling wrote: > This doesn't compile for me with: > > arch/powerpc/kernel/smp.c: In function ‘smp_prepare_cpus’: > arch/powerpc/kernel/smp.c:812:23: error: ‘tg.threads_per_group’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > struct thread_groups tg; > ^ > arch/powerpc/kernel/smp.c:812:23: error: ‘tg.nr_groups’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > cc1: all warnings being treated as errors > /home/mikey/src/linux-ozlabs/scripts/Makefile.build:305: recipe for target > 'arch/powerpc/kernel/smp.o' failed >
I couldn't get this error with gcc 4.8.5 and 8.1.1 with pseries_defconfig and powernv_defconfig with CONFIG_PPC_WERROR=y. Does the following the following delta patch make it work? -----------------------------X8---------------------------------- >From 6699ce20573dddd0d3d45ea79015751880740e9b Mon Sep 17 00:00:00 2001 From: "Gautham R. Shenoy" <e...@linux.vnet.ibm.com> Date: Fri, 21 Sep 2018 22:43:05 +0530 Subject: [PATCH] powerpc/smp: Initialize thread_groups local variable Signed-off-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com> --- arch/powerpc/kernel/smp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 5cdcf44..356751e 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -809,8 +809,9 @@ static int init_cpu_l1_cache_map(int cpu) { struct device_node *dn = of_get_cpu_node(cpu, NULL); - struct thread_groups tg; - + struct thread_groups tg = {.property = 0, + .nr_groups = 0, + .threads_per_group = 0}; int first_thread = cpu_first_thread_sibling(cpu); int i, cpu_group_start = -1, err = 0; -- 1.9.4