Re: [PATCH] powerpc/tm: Remove struct thread_info param from tm_reclaim_thread()

[Michael Ellerman]

Cyril Bur <cyril...@gmail.com> writes:

> tm_reclaim_thread() doesn't use the parameter anymore, both callers have
> to bother getting it as they have no need for a struct thread_info
> either.

In future please tell me why the parameter is unused and when it became
unused.

In this case it was previously used but the last usage was removed in:

dc3106690b20 ("powerpc: tm: Always use fp_state and vr_state to store live 
registers")

cheers

> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index bfdd783e3916..a47498da6562 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -853,8 +853,7 @@ static inline bool tm_enabled(struct task_struct *tsk)
>       return tsk && tsk->thread.regs && (tsk->thread.regs->msr & MSR_TM);
>  }
>  
> -static void tm_reclaim_thread(struct thread_struct *thr,
> -                           struct thread_info *ti, uint8_t cause)
> +static void tm_reclaim_thread(struct thread_struct *thr, uint8_t cause)
>  {
>       /*
>        * Use the current MSR TM suspended bit to track if we have
> @@ -901,7 +900,7 @@ static void tm_reclaim_thread(struct thread_struct *thr,
>  void tm_reclaim_current(uint8_t cause)
>  {
>       tm_enable();
> -     tm_reclaim_thread(&current->thread, current_thread_info(), cause);
> +     tm_reclaim_thread(&current->thread, cause);
>  }
>  
>  static inline void tm_reclaim_task(struct task_struct *tsk)
> @@ -932,7 +931,7 @@ static inline void tm_reclaim_task(struct task_struct 
> *tsk)
>                thr->regs->ccr, thr->regs->msr,
>                thr->regs->trap);
>  
> -     tm_reclaim_thread(thr, task_thread_info(tsk), TM_CAUSE_RESCHED);
> +     tm_reclaim_thread(thr, TM_CAUSE_RESCHED);
>  
>       TM_DEBUG("--- tm_reclaim on pid %d complete\n",
>                tsk->pid);
> -- 
> 2.16.1