Re: [PATCH 02/24] powerpc/mm: Pre-filter SRR1 bits before do_page_fault()

[Michael Ellerman]

LEROY Christophe <christophe.le...@c-s.fr> writes:
> Benjamin Herrenschmidt <b...@kernel.crashing.org> a écrit :
>> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
>> index faddc87d0205..f04bc9f6b134 100644
>> --- a/arch/powerpc/mm/fault.c
>> +++ b/arch/powerpc/mm/fault.c
>> @@ -203,23 +203,13 @@ static int __do_page_fault(struct pt_regs  
>> *regs, unsigned long address,
>>      unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
>>      int code = SEGV_MAPERR;
>>      int is_write = 0;
>> -    int trap = TRAP(regs);
>> -    int is_exec = trap == 0x400;
>> +    int is_exec = TRAP(regs) == 0x400;
>
> Don't we have a tab/space issue here ?

We do:

  Warnings for commit 0f9b89d759ba 'powerpc/mm: Pre-filter SRR1 bits before 
do_page_fault()'
    Lines beginning with space in arch/powerpc/mm/fault.c
      +         int is_exec = TRAP(regs) == 0x400;

I can fix it up.

cheers