On Fri, 24 Feb 2017 00:46:08 +0530 "Naveen N. Rao" <naveen.n....@linux.vnet.ibm.com> wrote:
> On 2017/02/23 06:10PM, Masami Hiramatsu wrote: > > On Wed, 22 Feb 2017 19:23:40 +0530 > > "Naveen N. Rao" <naveen.n....@linux.vnet.ibm.com> wrote: > > > > > We indicate support for accepting sym+offset with kretprobes through a > > > line in ftrace README. Parse the same to identify support and choose the > > > appropriate format for kprobe_events. > > > > > > Signed-off-by: Naveen N. Rao <naveen.n....@linux.vnet.ibm.com> > > > --- > > > tools/perf/util/probe-event.c | 47 > > > ++++++++++++++++++++++++++++++++++++------- > > > tools/perf/util/probe-event.h | 2 ++ > > > 2 files changed, 42 insertions(+), 7 deletions(-) > > > > > [snip] > > > > > Could you reuse (refactoring) probe_type_is_available() in probe-file.c to > > share > > opening README file? > > Done. I've sent patches to do that, please review. OK. > > > > > Others looks good to me :) > > Thanks. I hope that's an Ack for this patchset? OK, for 1/5, 2/5, 3/5, and 5/5; Acked-by: Masami Hiramatsu <mhira...@kernel.org> And could you make v4 series including all patches? (Not only updates) > > If so, and if Ingo/Michael agree, would it be ok to take the kernel bits > through the powerpc tree like we did for kprobe_exceptions_notify() > cleanup? If it is not urgent (yes, it seems) and since it changes arch independent parts, I think this series should finally go through Ingo's tree. Thank you, -- Masami Hiramatsu <mhira...@kernel.org>
