Stephen Rothwell wrote: >> +++ b/libfdt/libfdt.h > >> +#define FDT_ERR_BADDEPTH 8 > > Wouldn't it have been less intrusive to just use the next error number > rather than inserting this here?
Yes, but then either the order in errtable[] wouldn't match the order in the header file, or the error type grouping would be broken. If we want to maintain such a grouping, we should probably leave some number space between the groups. >> + * fdt_getprop_offset - retrieve the value of a given property by offset >> + * @fdt: pointer to the device tree blob >> + * @propoffset: offset of the property to read >> + * @name: pointer to a character pointer (will be overwritten) or NULL > ^^^^^^^^^^^^^^^^^ > "string"? "pointer to a string" could be interpreted as "char *", not "char **". I'll fix the others; thanks for pointing them out. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
