On Fri, 2007-12-14 at 16:52 +0800, Kumar Gala wrote: > > On Dec 14, 2007, at 2:47 AM, Li Tony wrote: > > > > > Hi, > > > > I think it is possible to make common code to support both IPIC > and > > MPIC. > > Currently, the MPIC has already implemented MSI which is different > > from IPIC and embedded into the mpic code body. > > If want to unifiy MSI code, we need to remove the current MPIC MSI > > implementation. > > The MPIC is going to have to support several MSI styles (IBM/U3, > PaSemi, and FSL) since we all seem to handle it differently. >
Yes, you are right. I misunderstands here. > > Micheal, what is your opinion ?? > > > > Jin is working on 86xx msi now. > > What PCIe cards are you using to test MSIs? > Intel PRO1000 PCIE network card and SysKonnect card. > - k > > >> -----Original Message----- > >> From: Kumar Gala [mailto:[EMAIL PROTECTED] > >> Sent: 2007年12月14日 13:45 > >> To: Li Tony > >> Cc: Phillips Kim; [EMAIL PROTECTED]; linuxppc-dev > >> Subject: Re: [PATCH 2/2] powerpc: Add IPIC MSI support > >> > >> > >> On Dec 4, 2007, at 4:39 AM, Li Li wrote: > >> > >>> Modified based on discussion on list. > >>> > >>> 1. Adopt virq_to_hw routine > >>> 2. Correct a legacy bug > >>> > >>> Implements the IPIC MSI as two level interrupt controller. > >>> > >>> Signed-off-by: Tony Li <[EMAIL PROTECTED]> > >> > >> Tony, have you looked at the 85xx/86xx PCIe MSI mechanism? > >> The 2nd level PIC handling seems like its pretty similar > >> between IPIC and MPIC. Would like to see if we could somehow > >> make the code common for to handle MSIs from both? > >> > >> - k > >> > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev