> >> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL > >> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL > > > > Should that really be just PPC_83xx || QUICC_ENGINE? > > Well, I thought about that. By now I'm unsure if every QE > implementation will be compatible with further ones.
How many other QE implementations exist? Is that sort of gratuitous breakage something Freescale makes a habit of? > So far > I've tested this driver on MPC8323 and MPC8568. If we'll see > more and more compatible QE SPI controllers, of course we > may just do || QUICC_ENGINE. > > PPC_83xx || PPC_85xx > PPC_83xx || QUICC_ENGINE > > Today first option saves us four bytes. ;-) It'd be good if someone would look at the relevant docs. I'll wait for a PPC signoff before I forward this for merge with SPI stuff... _ Dave _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
