Arnd Bergmann wrote: > On Monday 30 July 2007, Dave Jiang wrote: >> I don't believe that EDAC core has been loaded at the time of 85xx PCI >> initialization. Plus, the EDAC driver can be loaded as a kernel module. So >> that >> probably won't work.... > > ok, good point. > >> Also, instead of having centralized EDAC chip driver, >> now you have things scattered over various places. One probably needs to add >> 83xx and 86xx code as well and whatever else eventually. >> >> Maybe we are just better off adding entries in the DTS to get around this >> problem.... > > The best solution may be to look at how it's structured at the > register level. If the PCI EDAC registers are implemented separately > from the regular PCI registers, a device tree entry would be appropriate. > If not, your idea of registering a platform_device from fsl_add_bridge > is probably more sensible.
Actually it seems that for me to grab the interrupt number I have to do the platform device creation in fsl_soc.c and call arch_init() instead of doing it from fsl_add_bridge(). fsl_add_bridge() is called way too early and the mpic interrupt mapping has not been setup yet for me to acquire the interrupt number from of_interrupt_to_resource() call. -- ------------------------------------------------------ Dave Jiang Software Engineer MontaVista Software, Inc. http://www.mvista.com ------------------------------------------------------ _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
