On Wed, 2007-07-11 at 19:49 +0200, Segher Boessenkool wrote:
> > + UIC0: interrupt-controller0 {
>
> Why not just "interrupt-controller"?
Copy/paste error from Ebony DTS, which has multiple UICs. Will fix.
>
> > + #address-cells = <0>;
> > + #size-cells = <0>;
>
> No need for these.
Ok.
> >
> > + plb {
> > + ranges;
>
> Please make the valid address ranges explicit here.
Meaning what exactly? I thought just specifying "ranges;" simply said
"the addresses from this node don't have any translation from the parent
node" (or something like that).
>
> > + SDRAM0: memory-controller {
> > + compatible = "ibm,sdram-405gp", "ibm,sdram-440gp";
>
> It's a bit weird to mention 440 here, since 405 is older.
> Not a real problem, but if you still can change all relevant
> OS code and device trees, I'd swap it around (make 440 trees
> include the 405 "compatible" value). Can you still do that
> or is there a too big installed base already?
The installed base for 440 exists of exactly 1 completely non-functional
board ;). I can change it.
>
> > + POB0: opb {
> > + ranges;
>
> Similar question as for PLB here.
>
> > + UART0: [EMAIL PROTECTED] {
> > + current-speed = <2580>;
>
> Write this in decimal?
In a comment? Or?
> Quite a nice tree btw :-)
Thanks! Easy to do when there's nothing in it ;)
josh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
