On Wed, Sep 28, 2016 at 04:05:25PM +0300, Felipe Balbi wrote:
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
> 
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: <linux-usb@vger.kernel.org>
> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com>
> ---
>  drivers/usb/core/devices.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/core/devices.c b/drivers/usb/core/devices.c
> index ef04b50e6bbb..00d1b26a81d3 100644
> --- a/drivers/usb/core/devices.c
> +++ b/drivers/usb/core/devices.c
> @@ -182,14 +182,8 @@ static char *usb_dump_endpoint_descriptor(int speed, 
> char *start, char *end,
>  
>       dir = usb_endpoint_dir_in(desc) ? 'I' : 'O';
>  
> -     if (speed == USB_SPEED_HIGH) {
> -             switch (usb_endpoint_maxp(desc) & (0x03 << 11)) {

This is 0 based,

> -             case 1 << 11:
> -                     bandwidth = 2; break;
> -             case 2 << 11:
> -                     bandwidth = 3; break;
> -             }
> -     }
> +     if (speed == USB_SPEED_HIGH)
> +             bandwidth = usb_endpoint_maxp_mult(desc);

Now the new code makes it 1 based.

Regards,
-Bin.

>  
>       /* this isn't checking for illegal values */
>       switch (usb_endpoint_type(desc)) {
> -- 
> 2.10.0.440.g21f862b
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to