On Wed, Sep 28, 2016 at 04:05:49PM +0300, Felipe Balbi wrote: > Now that usb_endpoint_maxp() only returns the lowest > 11 bits from wMaxPacketSize, we can remove the & > operation from this driver. > > Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> > --- > drivers/usb/gadget/udc/s3c2410_udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c > b/drivers/usb/gadget/udc/s3c2410_udc.c > index eb3571ee59e3..4643a01262b4 100644 > --- a/drivers/usb/gadget/udc/s3c2410_udc.c > +++ b/drivers/usb/gadget/udc/s3c2410_udc.c > @@ -1047,10 +1047,10 @@ static int s3c2410_udc_ep_enable(struct usb_ep *_ep, > if (!dev->driver || dev->gadget.speed == USB_SPEED_UNKNOWN) > return -ESHUTDOWN; > > - max = usb_endpoint_maxp(desc) & 0x1fff; > + max = usb_endpoint_maxp(desc);
This loses bit 11 & 12. Regards, -Bin. > > local_irq_save(flags); > - _ep->maxpacket = max & 0x7ff; > + _ep->maxpacket = max; > ep->ep.desc = desc; > ep->halted = 0; > ep->bEndpointAddress = desc->bEndpointAddress; > -- > 2.10.0.440.g21f862b > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
