On Wed, 2016-09-28 at 12:29 +0200, Ladislav Michl wrote:
> Well, reference counting is also suspicious as kref_get(&data->kref)
> in
> probe function with comment "will reference data in int urb" gives no
> clue why there's explicit reference. Also what if we add classic
> error unwinding and leave usb_submit_urb to open time? But wait, this
> driver allows multiple opens? Is it intentional? It could be done this
> way (note patch is only for reference as there's nothing to prevent
> multiple open and therefore multiple usb_submit_urb):
You need to check "zombie" in open() or you open up to another
race.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
