Hi, Krzysztof Opasiak <k.opas...@samsung.com> writes: > From: Igor Kotrasinski <i.kotrasi...@samsung.com> > > Add endpoints definitions and ops for both endpoints and gadget. > Add also a suitable platform driver and functions for handling > usbip events. > > This commit is a result of cooperation between Samsung R&D Institute > Poland and Open Operating Systems Student Society at University > of Warsaw (O2S3@UW) consisting of: > > Igor Kotrasinski <ikotrasi...@gmail.com> > Karol Kosik <ka...@interia.eu> > Ewelina Kosmider <3w3l...@gmail.com> > Dawid Lazarczyk <lazarczyk.da...@gmail.com> > Piotr Szulc <ps347...@students.mimuw.edu.pl> > > Tutor and project owner: > Krzysztof Opasiak <k.opas...@samsung.com> > > Signed-off-by: Igor Kotrasinski <i.kotrasi...@samsung.com> > Signed-off-by: Karol Kosik <ka...@interia.eu> > [Various bug fixes, improvements and commit msg update] > Signed-off-by: Krzysztof Opasiak <k.opas...@samsung.com>
just a couple minor nits below. Nice work
> +struct vep *find_endpoint(struct vudc *udc, u8 address)
polluting namespace. Care to add 'static'?
> +static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req)
> +{
> + struct vrequest *req;
> +
> + if (!_ep || !_req) {
> + WARN_ON(1);
> + return;
> + }
if (WARN_ON(!_ep || !_req))
return;
--
balbi
signature.asc
Description: PGP signature
