On Tue, 25 Nov 2014, Felipe Balbi wrote: > Hi, > > On Tue, Nov 25, 2014 at 02:44:16AM +0100, Ricardo Ribalda Delgado wrote: > > > might be better if you can fix the code, instead. We have a "better" > > > scatter-gather support in the framework itself. > > > > As I understand it, the code was designed to reduce the number of irqs > > when you expect to send X consecutive packages. In that scenario you > > only want an irq at the end. ie, u_ether supports it. It was not > > designed for sg. > > > > The problem is that the driver only allocates one sg descriptor per > > endpoint, without the possibility of chaining the request I dont see > > right, but what I'm is that we don't want the UDC manually allocating SG > lists and moving req->buf to that sg, we want the gadget driver to pass > a properly formatted sg to the UDC. Currently, only UASP implementation > on top of target framework is doing that. Eventually, we should have > more functions passing sgs to the UDC. > > > how can this can work. And it does not work on my hw. > > > > If you could confirm what I am saying about the dma_chaining by > > testing it on net2280 then I think we should remote the module > > parameter, because it will only confuse the user and also ofuscates a > > lot the code. > > Unfortunately I don't have net2280 and I keep forgetting if Alan has > net2280 or net2272.
I have a net2280, and I can test patches. Unfortunately, it has been so many years since I worked on the net2280 driver that I don't remember what "dma_chaining" does. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
