On Tue, 25 Nov 2014, Ricardo Ribalda Delgado wrote: > Now that I open the pandora box.... > > Is there any reason to have use_dma, use_msi, enable_suspend and > full_speed as parameters? I might as well remove them.
I think the use_dma parameter was from the early days when the DMA code didn't work very well and we needed to leave it turned off most of the time. There doesn't seem to be any need for use_msi (assuming it is reliable). enable_suspend is a special case. It's meant for use in embedded applications; when your controller is a PCI card plugged into a PC it's not useful (except for testing). The full_speed parameter was also just for testing; it forces the net2280 to connect at full speed rather than at high speed. It isn't much good for general use, and I probably should never have submitted it in the first place -- keeping it as a local patch would be sufficient for my needs. It you want, you can revert the commit which added it (2f0760774711). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
