On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Factor portions of it out. > > Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
Acked-by: Michal Nazarewicz <min...@mina86.com>
> ---
> drivers/usb/gadget/f_mass_storage.c | 81 +++++++++++++++++++++++++++-------
> drivers/usb/gadget/f_mass_storage.h | 8 +++
> 2 files changed, 72 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c
> index 4833710..16a44e1 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> +void _fsg_common_remove_luns(struct fsg_common *common, int n)
Since this function is used only in this file and not exported, why not
mark it static?
> +{
> + int i;
> +
> + for (i = 0; i < n; ++i)
> + if (common->luns[i]) {
> + fsg_common_remove_lun(common->luns[i], common->sysfs);
> + common->luns[i] = NULL;
> + }
> +}
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<m...@google.com>--<xmpp:min...@jabber.org>--ooO--(_)--Ooo--
signature.asc
Description: PGP signature
