On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Factor a portion of it out. > > Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
Acked-by: Michal Nazarewicz <min...@mina86.com>
> ---
> drivers/usb/gadget/f_mass_storage.c | 41 +++++++++++++++++++++-------------
> 1 files changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c
> index 14c9e5b..b7ed792 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -2643,6 +2643,28 @@ static inline int fsg_num_buffers_validate(unsigned
> int fsg_num_buffers)
> return -EINVAL;
> }
>
> +static struct fsg_common *fsg_common_setup(struct fsg_common *common, bool
> zero)
I don't see the point of zero argument.
> +{
> + if (!common) {
> + common = kzalloc(sizeof(*common), GFP_KERNEL);
> + if (!common)
> + return ERR_PTR(-ENOMEM);
> + common->free_storage_on_release = 1;
> + } else {
> + if (zero)
> + memset(common, 0, sizeof(*common));
> + common->free_storage_on_release = 0;
> + }
> + init_rwsem(&common->filesem);
> + spin_lock_init(&common->lock);
> + kref_init(&common->ref);
> + init_completion(&common->thread_notifier);
> + init_waitqueue_head(&common->fsg_wait);
> + common->state = FSG_STATE_TERMINATED;
> +
> + return common;
> +}
> +
> void fsg_common_set_sysfs(struct fsg_common *common, bool sysfs)
> {
> common->sysfs = sysfs;
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<m...@google.com>--<xmpp:min...@jabber.org>--ooO--(_)--Ooo--
signature.asc
Description: PGP signature
