On Tue, Mar 20, 2018 at 02:03:46AM -0700, Daniel Gimpelevich wrote: > On Tue, 2018-03-20 at 09:36 +0100, Greg KH wrote: > > Who is "Rab" and why do you need to name who added what id to the > > patch? > > > I copied that part from the web page I referenced in the commit message. > It's evidently a reference to the page's author. I tried to send an > e-mail to the address at the bottom of the page, with no response. I > also CC'ed from git send-email. > > > > What is more useful is a description of the device types, not who > > added > > the new id, can you do that instead? > > For the "Rab" devices, there is a wealth of such information on the > aforementioned web page. I added the info for the ones I have into the > commit message. > > > It doesn't say that Fabio added this one below, are you sure? > > It says that in the commit that added it: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/uss720.c?id=ecc1624a2fff45780959efbcb73ace18fdb3c58d
Ok, but that isn't needed in the comments of the code. Put the device "type" or "name" as a comment, that makes more sense and follows what almost all other drivers do. > > Always use scripts/get_maintainer.pl to figure out who to cc: on the > > patches, otherwise the maintainer might miss it :( > > Hmm, I simply looked in the MAINTAINERS file instead, which has no entry > for this driver. If there is no default, it falls back to the maintainer(s) of the subsystem, which get_maintainer.pl knows how to handle. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
