On Thu, Dec 13, 2007 at 09:35:16PM -0800, Greg KH wrote: > On Thu, Dec 13, 2007 at 09:45:23PM -0500, Dave Jones wrote: > > On Thu, Dec 13, 2007 at 06:20:56PM -0800, Sarah Sharp wrote: > > > > Hi Sarah, > > > > > Signed-off-by: Sarah Sharp <[EMAIL PROTECTED]> > > > --- > > > drivers/usb/serial/pl2303.c | 42 > > +++++++++++++++++++++--------------------- > > > 1 files changed, 21 insertions(+), 21 deletions(-) > > > > There's a lot of code motion in the first four patches > > (with no explanation) that seems to be greatly larger than > > the net effect of applying all four patches. > > I did so, just to see the end result, which was a lot more 'reviewable', > > ending up with this.. > > Heh, yes, Sarah, why all the intermediate steps?
I originally had one giant patch to move the vendor specific initialization into the probe function and clean up the FISH/SOUP at the same time. When I reviewed it with Jamey, he said it was difficult to tell if the patch was correct just by looking at it. He suggested breaking it up into smaller patches that were obviously correct. But if you want the big patch, I'll happily send that. > What were you trying to do there? Please make better changelog comments so we > can understand. Sure. What I was basically trying to do was get rid of an ugly macro that didn't follow the rules in CodingStyle, since it assigned to local variables that weren't passed in and didn't wrap multiple lines of code in a do-while loop. It was much clearer as a function. Once it was redefined as a function, it was easy to move the vendor specific commands that did initialization into the probe function. Sarah - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
