On Thu, Dec 13, 2007 at 09:45:23PM -0500, Dave Jones wrote:
> On Thu, Dec 13, 2007 at 06:20:56PM -0800, Sarah Sharp wrote:
> 
> Hi Sarah,
> 
>  > Signed-off-by: Sarah Sharp <[EMAIL PROTECTED]>
>  > ---
>  >  drivers/usb/serial/pl2303.c |   42 
> +++++++++++++++++++++---------------------
>  >  1 files changed, 21 insertions(+), 21 deletions(-)
> 
> There's a lot of code motion in the first four patches
> (with no explanation) that seems to be greatly larger than
> the net effect of applying all four patches.
> I did so, just to see the end result, which was a lot more 'reviewable',
> ending up with this..

Heh, yes, Sarah, why all the intermediate steps?  What were you trying
to do there?  Please make better changelog comments so we can
understand.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to