On Wed, 9 Apr 2025 19:30:19 +0200 Danilo Krummrich <d...@kernel.org> wrote:
>> On Wed, 9 Apr 2025 at 16:48, Miguel Ojeda >> <miguel.ojeda.sando...@gmail.com> wrote: >> > On Wed, Apr 9, 2025 at 8:16 AM FUJITA Tomonori >> > <fujita.tomon...@gmail.com> wrote: >> > > >> > > Align iounmap() signature with other architectures. >> > >> > Most indeed have `volatile`, but nios2 and m68k don't -- Cc'ing them >> > just in case. >> >> Indeed. Apparently the volatile keyword has not always been there... >> Why does iounmap() need the volatile keyword? >> Why does pci_iounmap() not have the volatile keyword? > > I think none of the functions within rust/helpers/io.c need volatile, since > they > just defer to the corresponding C function / macro. Yeah, all volatile in the file should be safe to remove. I'll go with that approach for the next version. I think it would be nice to have the same function signature across all architectures, but that's a separate topic. Thanks,
