On Wed, Apr 09, 2025 at 07:07:56PM +0200, Geert Uytterhoeven wrote: > Hi Miguel, > > CC arnd > > On Wed, 9 Apr 2025 at 16:48, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: > > On Wed, Apr 9, 2025 at 8:16 AM FUJITA Tomonori > > <fujita.tomon...@gmail.com> wrote: > > > > > > Align iounmap() signature with other architectures. > > > > Most indeed have `volatile`, but nios2 and m68k don't -- Cc'ing them > > just in case. > > Indeed. Apparently the volatile keyword has not always been there... > Why does iounmap() need the volatile keyword? > Why does pci_iounmap() not have the volatile keyword?
I think none of the functions within rust/helpers/io.c need volatile, since they just defer to the corresponding C function / macro. This probably has been a copy/paste mistake of the function signatures and should be removed instead. - Danilo
