On Thu, 25 Jun 2026 00:36:49 +0200
Linus Walleij <[email protected]> wrote:
> Hi Dmitry,
>
> thanks for your patch!
>
> Also nice to see some kernel contributions directly from
> MobilEye!
Thanks for you review!
> > struct nmk_i2c_dev {
> > struct i2c_vendor_data *vendor;
> > @@ -206,13 +206,13 @@ struct nmk_i2c_dev {
> > u32 clk_freq;
> > unsigned char tft;
> > unsigned char rft;
>
> ^
> Maybe you want to take the opportunity to change these
> two into u8 if you're anyway changing the layout of this
> struct?
I'm waiting for review of patch 1 in the set. If I need to submit next
version of the patchset, I'll change these two unsigned chars, as well
as `unsigned char *buffer` in `struct i2c_nmk_client`, into u8.
Best Regards,
--
Dmitry Guzman <[email protected]>
