On Mon, Jun 29, 2026 at 11:40:13AM -0400, Gregory Price wrote: > On Mon, Jun 29, 2026 at 01:23:14PM +0100, Lorenzo Stoakes wrote: > > Now we have the vma_start_pgoff() helper, update the merge tests to make > > use of it for consistency. > > > > No functional change intended. > > > > Signed-off-by: Lorenzo Stoakes <[email protected]> > > Question: Should we have primitive tests for vma_*_pgoff() since > the behavior changes depending on file/anon? > > Nice to have the cleanup and clarity. Maybe worth asserting no > one ever breaks this.
Well funny you should mention that :) I do add some asserts as I go. In my RFC series which this series is the predicate for, I add more as then we track virtal page off separately (see [0]). Amusingly (or not) /dev/zero breaks assumptions a bit (anonymous VMA with vma->vm_file that tracks by file index, just glroious). But I plan to fix that later! > > for this patch though > > Reviewed-by: Gregory Price <[email protected]> Thanks! Cheers, Lorenzo [0]:https://lore.kernel.org/linux-mm/[email protected]/
