On 6/5/26 10:12, Xie Yuanbin wrote:
> For historical version, commit 97f0b1345219 ("tracing: add trace event
> for memory-failure") introduced memory_failure_event in ras subsystem.
> commit 31807483d395 ("mm/memory-failure: remove the selection of RAS")
> changed memory_failure_event to memory_failure subsystem. This breaks
> the backward compatibility, some user programs rely on it.
>
> Change memory_failure_event to ras subsystem to keep backward
> compatibility.
>
> Fixes: 31807483d395 ("mm/memory-failure: remove the selection of RAS")
>
> Reported-by: Yi Lai <[email protected]>
> Reported-by: Qiuxu Zhuo <[email protected]>
> Closes:
> https://lore.kernel.org/linux-mm/cy8pr11mb7134346a3e4bb28eca28d6e989...@cy8pr11mb7134.namprd11.prod.outlook.com
> Cc: David Hildenbrand <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Miaohe Lin <[email protected]>
> Signed-off-by: Xie Yuanbin <[email protected]>
> ---
> include/trace/events/memory-failure.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/memory-failure.h
> b/include/trace/events/memory-failure.h
> index aa57cc8f896b..7a8ee5d1a44e 100644
> --- a/include/trace/events/memory-failure.h
> +++ b/include/trace/events/memory-failure.h
> @@ -1,6 +1,10 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #undef TRACE_SYSTEM
> -#define TRACE_SYSTEM memory_failure
> +/*
> + * For historical versions, memory_failure_event is in ras subsystem,
> + * some user programs depend on it.
> + */
> +#define TRACE_SYSTEM ras
> #define TRACE_INCLUDE_FILE memory-failure
>
> #if !defined(_TRACE_MEMORY_FAILURE_H) || defined(TRACE_HEADER_MULTI_READ)
We should
Cc: <[email protected]>
given that it's in v6.19 and nobody noticed :(
Acked-by: David Hildenbrand (Arm) <[email protected]>
Thanks, and fortunately now I learned about possible ABI salability of trace
events.
--
Cheers,
David
