On Sat, 30 May 2026 22:19:21 +0100
David Laight <[email protected]> wrote:

> > +/*                                                         \
> > + * The probestub is only used for tprobes and not referenced       \
> > + * anywhere else. This causes objtool to think it's not called     \
> > + * at all and will add it to the seal list which will remove       \
> > + * the ENDBR causing issues if a tprobe is ever used.              \
> > + */                                                                \  
> 
> Isn't the sense of that all wrong?

The above is still correct. It just expresses what the probestub is
used for.

> Maybe:
>       Annotate the protosub 'CFI_NOSEAL' to stop objtool requesting the
>       kernel remove the ENDBR because the only references to the
>       function are in the __tracepoint section that objtool doesn't scan.

I do agree that your version is a bit more concise.

Thanks,

-- Steve

Reply via email to