ne 7. 9. 2025 v 4:23 odesÃlatel Crystal Wood <crw...@redhat.com> napsal: > > v2: minor changes from Tomas's feedback >
Thank you! Looks good now. (The help message for rtla-osnoise-top shows --on-end without the argument, but that is my typo (it's also in timerlat), let's just fix that later.) > v1: > https://lore.kernel.org/linux-trace-kernel/20250821035719.137161-1-crw...@redhat.com/T/#t > > Costa Shulyupin (1): > tools/rtla: Consolidate common parameters into shared structure > > Crystal Wood (6): > tools/rtla: Move top/hist params into common struct > tools/rtla: Create common_apply_config() > tools/rtla: Consolidate code between osnoise/timerlat and hist/top > tools/rtla: Fix -A option name in test comment > tools/rtla: Add test engine support for unexpected output > tools/rtla: Add remaining support for osnoise action > > Documentation/tools/rtla/common_options.rst | 61 ++ > .../tools/rtla/common_osnoise_options.rst | 8 + > .../tools/rtla/common_timerlat_options.rst | 74 +- > Documentation/tools/rtla/rtla-hwnoise.rst | 2 + > .../tools/rtla/rtla-osnoise-hist.rst | 2 + > Documentation/tools/rtla/rtla-osnoise-top.rst | 2 + > .../tools/rtla/rtla-timerlat-hist.rst | 2 + > .../tools/rtla/rtla-timerlat-top.rst | 2 + > tools/tracing/rtla/src/Build | 1 + > tools/tracing/rtla/src/actions.c | 8 +- > tools/tracing/rtla/src/actions.h | 2 +- > tools/tracing/rtla/src/common.c | 344 ++++++++++ > tools/tracing/rtla/src/common.h | 154 +++++ > tools/tracing/rtla/src/osnoise.c | 101 ++- > tools/tracing/rtla/src/osnoise.h | 114 +--- > tools/tracing/rtla/src/osnoise_hist.c | 369 ++++------ > tools/tracing/rtla/src/osnoise_top.c | 303 +++------ > tools/tracing/rtla/src/timerlat.c | 210 ++++-- > tools/tracing/rtla/src/timerlat.h | 55 +- > tools/tracing/rtla/src/timerlat_bpf.c | 22 +- > tools/tracing/rtla/src/timerlat_hist.c | 642 +++++------------- > tools/tracing/rtla/src/timerlat_top.c | 568 ++++------------ > tools/tracing/rtla/src/trace.h | 3 - > tools/tracing/rtla/tests/engine.sh | 26 +- > tools/tracing/rtla/tests/osnoise.t | 27 +- > tools/tracing/rtla/tests/timerlat.t | 4 +- > 26 files changed, 1395 insertions(+), 1711 deletions(-) > create mode 100644 tools/tracing/rtla/src/common.c > create mode 100644 tools/tracing/rtla/src/common.h > > -- > 2.48.1 > Reviewed-by: Tomas Glozar <tglo...@redhat.com> Tomas
