On Sun, 7 Sept 2025 at 05:23, Crystal Wood <crw...@redhat.com> wrote:
> -static struct osnoise_params
> +static struct common_params
>  *osnoise_hist_parse_args(int argc, char *argv[])

> -static struct timerlat_params
> +static struct common_params
>  *timerlat_hist_parse_args(int argc, char *argv[])

> -static struct timerlat_params
> +static struct common_params
>  *timerlat_top_parse_args(int argc, char **argv)
>  {

Why do you replace specific params with common params, breaking the hierarchy?
common_params is meant to remain at the lower level - tool-agnostic
and reusable across tools.

Costa


Reply via email to