Replace kmalloc() followed by copy_from_user() with memdup_user() to
improve and simplify osnoise_cpus_write().

No functional changes intended.

Signed-off-by: Thorsten Blum <thorsten.b...@linux.dev>
---
 kernel/trace/trace_osnoise.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index fd259da0aa64..dd97f6bd03a4 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c
@@ -2322,12 +2322,9 @@ osnoise_cpus_write(struct file *filp, const char __user 
*ubuf, size_t count,
        int running, err;
        char *buf __free(kfree) = NULL;
 
-       buf = kmalloc(count, GFP_KERNEL);
-       if (!buf)
-               return -ENOMEM;
-
-       if (copy_from_user(buf, ubuf, count))
-               return -EFAULT;
+       buf = memdup_user(ubuf, count);
+       if (IS_ERR(buf))
+               return PTR_ERR(buf);
 
        if (!zalloc_cpumask_var(&osnoise_cpumask_new, GFP_KERNEL))
                return -ENOMEM;
-- 
2.51.0


Reply via email to