On Tue, 2025-08-05 at 10:03 +0300, Costa Shulyupin wrote: > On Mon, 4 Aug 2025 at 21:18, Crystal Wood <[email protected]> wrote: > > If you want, I could rebase that on this and use container_of() to for tool- > > specific params... but then that adds complexity with the top and hist- > > specific params, most of which are common between timerlat and osnoise > > (and not merged by this patch). > I’d appreciate it if you could rebase your patchset on top of this one.
OK. > This patch is just the first; I’ve intentionally kept it minimal to > ease integration. > My goal is to refactor rtla and submit a series of follow-up patches > to reduce code duplication. I have consolidation patches that are just about ready to submit; I'll try to get them polished and pushed soon. > So we might want to just keep it simple with one big struct. > This is a god object anti-pattern. I know, but I was trying to weigh that against pragmatism and churn reduction, at least for an initial refactoring -- particularly given that my motivation was to make it easier to make a timerlat-specific feature work on osnoise as well. -Crystal
