On Mon, 7 Jul 2025 15:42:45 -0400 Steven Rostedt <[email protected]> wrote:
> On Fri, 4 Jul 2025 14:20:54 -0400 > Mathieu Desnoyers <[email protected]> wrote: > > > > None of the structures introduced will be exposed to user space tooling. > > > > > > > Would it be possible to make those unwind APIs EXPORT_SYMBOL_GPL > > so they are available for GPL kernel modules ? > > I'm OK with that, but others tend to complain about EXPORT_SYMBOL_GPL > for functions not used by modules in the kernel. But I personally feel > that LTTng should get an exception for that rule ;-) I just noticed that this was to patch 1. The functions here probably shouldn't be exported as they are more internal to the infrastructure. In fact, I think I'll move that macro into the user.c code. I don't think it should be used outside that function. And the unwind_user_start/next() could also be static functions. -- Steve
