On Tue, Feb 07, 2017 at 11:27:38AM +0000, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> The check on rcode >= 0 is always true because rcode is unsigned
> and can never be less than zero. Remove the redundant check.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/scsi/aacraid/aachba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 3b5ddf4..ddfd726 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct
> fib *fibptr, int rescan)
> FsaNormal, 1, 1, NULL, NULL);
>
> /* analyse data */
> - if (rcode >= 0 && phys_luns->resp_flag == 2) {
The original code is buggy. rcode should be an int.
regards,
dan carpenter
