On 04/25/2016 09:16 AM, Douglas Gilbert wrote:
@@ -580,8 +580,8 @@ static int sdebug_sectors_per; /* sectors per cylinder */static unsigned int scsi_debug_lbp(void) { - return ((0 == scsi_debug_fake_rw) && - (scsi_debug_lbpu | scsi_debug_lbpws | scsi_debug_lbpws10)); + return ((0 == sdebug_fake_rw) && + (sdebug_lbpu | sdebug_lbpws | sdebug_lbpws10)); }
Since you are changing this code, please remove the superfluous parentheses, place the constant at the right side of the comparison and change "|" into "||" since the intention of the above code is to perform a logical or and this code is not in a performance-critical path.
+ sdebug_verbose = !!(SDEBUG_OPT_NOISE & sdebug_opts); + sdebug_any_injecting_opt = !!(SDEBUG_OPT_ALL_INJECTING & sdebug_opts);
Same comment here: please put constants at the right side. I think the latest version of checkpatch requests to do so.
Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
