The size is to match the 64 bit address space command packet to the
adapter. A dma_addr_t is assigned to an u64 which ends up in a pair of
__le32's. We also issue 32 bit address space command packets where the
dma_addr_t is (truncated) into an u32 and placed into a single __le32.
The code style remains roughly the same for all three paths (32 bit
address io, 64 bit address io, 64 bit raw io) to cover all the different
generations of adapters.

The 'addr' is a hardware sized cpu ordered placeholder.

Sincerely -- Mark Salyzyn

-----Original Message-----
From: Arjan van de Ven [mailto:[EMAIL PROTECTED] 
Sent: Friday, August 05, 2005 10:45 AM
To: Mark Haverkamp
Cc: Salyzyn, Mark; linux-scsi; James Bottomley
Subject: RE: [PATCH 7/7] aacraid: sgraw command support

On Fri, 2005-08-05 at 07:24 -0700, Mark Haverkamp wrote:
> On Thu, 2005-08-04 at 07:40 -0400, Salyzyn, Mark wrote:
> > In these cases, the 'addr' is an u64, so is it necessary to perform
this
> > modification?
> 
> Arjan,
> 
> Do you agree with the above?  If so, is the patch OK as is?

Ok you're ok then. I just then in turn question why addr is actually a
u64, and not say, a dma_addr_t or something..




-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to