Hi Shunqian, On Fri, Dec 29, 2017 at 04:08:25PM +0800, Shunqian Zheng wrote: > Add device tree binding documentation for the OV2685 sensor.
DT bindings should precede the driver. Speaking of which --- you should add an entry in the MAINTAINERS file for both. > > Signed-off-by: Shunqian Zheng <[email protected]> > --- > .../devicetree/bindings/media/i2c/ov2685.txt | 35 > ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2685.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2685.txt > b/Documentation/devicetree/bindings/media/i2c/ov2685.txt > new file mode 100644 > index 0000000..85aec03 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov2685.txt > @@ -0,0 +1,35 @@ > +* Omnivision OV2685 MIPI CSI-2 sensor > + > +Required Properties: > +- compatible: should be "ovti,ov2685" > +- clocks: reference to the 24M xvclk input clock. > +- clock-names: should be "xvclk". > +- avdd-supply: Analog voltage supply, 2.8 volts > +- dvdd-supply: Digital core voltage supply, 1.2 volts > +- reset-gpios: Low active reset gpio > + > +The device node must contain one 'port' child node for its digital output s/must/shall/ Please add that the port shall contain one endpoint node as well. > +video port, in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. Which specific properties are required and which ones are optional? > + > +Example: > + ucam: camera-sensor@3c { > + compatible = "ovti,ov2685"; > + reg = <0x3c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cru SCLK_TESTCLKOUT1>; > + clock-names = "xvclk"; > + > + avdd-supply = <&pp2800_cam>; > + dovdd-supply = <&pp1800>; > + reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; > + > + port { > + ucam_out: endpoint { > + remote-endpoint = <&mipi_in_ucam>; > + data-lanes = <1>; > + }; > + }; > + }; -- Regards, Sakari Ailus e-mail: [email protected]
